On Wed, 29 Oct 2008 21:29:04 +0000
Ben Hutchings [off-list ref] wrote:

On Wed, 2008-10-29 at 14:22 -0700, akpm@linux-foundation.org wrote:

quoted

From: Andrew Morton <akpm@linux-foundation.org>

drivers/net/sfc/falcon.c: In function 'falcon_spi_write_limit':
drivers/net/sfc/falcon.c:1679: warning: comparison of distinct pointer types lacks a cast
drivers/net/sfc/falcon.c: In function 'falcon_spi_read':
drivers/net/sfc/falcon.c:1720: warning: comparison of distinct pointer types lacks a cast

These were already fixed by 31b760202a0911384fa07796df9d1905e9e89a7f.

That patch worsened things.

quoted

Driver seems rather confused about types.  Try to help it.

[...]

Maybe, but in order to fix that you'll need to revert
31b760202a0911384fa07796df9d1905e9e89a7f along with making these
changes.

I have plenty of things to be going on with.