Re: [PATCH] cipso: unsigned buf_len cannot be negative
From: Paul Moore <hidden>
Date: 2008-10-28 22:02:26
On Tuesday 28 October 2008 8:49:45 am you wrote:
unsigned buf_len cannot be negative Signed-off-by: Roel Kluin <redacted>
Acked-by: Paul Moore <redacted> Hi Roel, Nice catch, thanks for the patch. Dave, can you apply this patch even though it is in a reply and not the original form? If not let me know and I can re-send Roel's mail if he isn't able.
quoted hunk
---diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c index 490e035..2e78f6b 100644 --- a/net/ipv4/cipso_ipv4.c +++ b/net/ipv4/cipso_ipv4.c@@ -2063,9 +2063,10 @@ int cipso_v4_skbuff_setattr(struct sk_buff*skb, u32 opt_len; int len_delta; - buf_len = cipso_v4_genopt(buf, buf_len, doi_def, secattr); - if (buf_len < 0) - return buf_len; + ret_val = cipso_v4_genopt(buf, buf_len, doi_def, secattr); + if (ret_val < 0) + return ret_val; + buf_len = ret_val; opt_len = (buf_len + 3) & ~3; /* we overwrite any existing options to ensure that we have enough
-- paul moore linux @ hp