Re: [PATCH] Re: ep93xx_eth PHY problems
From: Lennert Buytenhek <hidden>
Date: 2008-09-14 11:47:52
On Sat, Sep 13, 2008 at 10:11:32PM -0400, Jeff Garzik wrote:
quoted
Am Tue, 04 Mar 2008 14:02:15 +0100 schrieb Oliver Martin [off-list ref]:quoted
Now I'm having different problems: When auto-negotiation is enabled, it sometimes randomly changes the link state: PHY: 0:01 - Link is Down PHY: 0:01 - Link is Up - 100/FullI've found at least one part of the problem. The MDIO clock divisor wasn't set again after the reset in ep93xx_start_hw. It was left at the default, resulting in a 12.5 MHz clock, which the PHY (Micrel KSZ8721BL) didn't like too much. Calling ep93xx_mdio_reset after the reset fixed it, the link is now perfectly stable in auto-negotiation mode. There still seems to be another bug with auto-negotiation disabled: It doesn't switch to 1000 Mbps any more, but most times it doesn't stay in the intended configuration either. I haven't done any extensive testing of this yet, though. Signed-off-by: Oliver Martin <redacted>Testing feedback? Lennert ack?
ACKed on March 29. Since this patch depends on Herbert Valerio Riedel's ep93xx_eth phylib conversion, I asked Herbert to resend his latest version of those patches at that time, but I didn't see that yet. Herbert, have you made changes to the ep93xx_eth phylib patch since you last posted it and/or what is the latest version?