[PATCH] ibm_newemac: Don't call dev_mc_add() before device is registered
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2008-08-17 21:29:41
Also in:
linuxppc-dev
We must not call dev_mc_add() from within our HW configure which happens before we initialize and register the netdev. Do it in open() instead. Thanks to Sebastian Siewior for tracking it down. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- This fixes an uninitialized spinlock warning (and possibly more). Please apply. Cheers, Ben. Index: linux-work/drivers/net/ibm_newemac/core.c ===================================================================
--- linux-work.orig/drivers/net/ibm_newemac/core.c 2008-08-14 13:36:10.000000000 +1000
+++ linux-work/drivers/net/ibm_newemac/core.c 2008-08-14 13:42:10.000000000 +1000@@ -663,9 +663,6 @@ static int emac_configure(struct emac_in if (emac_phy_gpcs(dev->phy.mode)) emac_mii_reset_phy(&dev->phy); - /* Required for Pause packet support in EMAC */ - dev_mc_add(ndev, default_mcast_addr, sizeof(default_mcast_addr), 1); - return 0; }
@@ -1150,6 +1147,9 @@ static int emac_open(struct net_device * } else netif_carrier_on(dev->ndev); + /* Required for Pause packet support in EMAC */ + dev_mc_add(ndev, default_mcast_addr, sizeof(default_mcast_addr), 1); + emac_configure(dev); mal_poll_add(dev->mal, &dev->commac); mal_enable_tx_channel(dev->mal, dev->mal_tx_chan);
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev