Thread (4 messages) 4 messages, 2 authors, 2008-08-31

Re: [PATCH 1/2] ne.c fix, res->name

From: Atsushi Nemoto <hidden>
Date: 2008-08-31 17:15:22
Also in: lkml

On Sat, 30 Aug 2008 13:05:03 -0500, David Fries [off-list ref] wrote:
On Sun, Aug 31, 2008 at 12:03:57AM +0900, Atsushi Nemoto wrote:
quoted
On Fri, 29 Aug 2008 21:44:25 -0500, David Fries [off-list ref] wrote:
quoted
+	if (!strcmp(res->name, BAD_STR))
+		dev->mem_end = BAD;
The res->name might be NULL.  You should check it first.

	if (res->name && !strcmp(res->name, BAD_STR))
		dev->mem_end = BAD;
The name gets a valid string by that point in time.

drivers/base/platform.c:257
Oh, you are right.  Sorry for noise.

---
Atsushi Nemoto
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help