Thread (8 messages) 8 messages, 5 authors, 2008-08-23

RE: [PATCH 4/4 2.6.28] cxgb3i - cxgb3i iscsi driver

From: <hidden>
Date: 2008-08-23 08:22:58
Also in: linux-scsi, lkml

Andrew Morton wrote:
quoted
+ *
+ * Written by: Karen Xie (kxie@chelsio.com)  */
+
+#include "cxgb3i.h"
+
+#define DRV_MODULE_NAME         "cxgb3i"
+#define DRV_MODULE_VERSION      "1.0.0"
I'd suggest that the version number just be removed.  It becomes
meaningless (and often misleading) once a driver is in the mainline
kernel.  People will >update the driver without changing the version
number.  Code external to the driver but which affects it can change.
The kernel version identifier is really the only way in whcih you and
your support people can reproduce a user's code.
quoted
+#define DRV_MODULE_RELDATE      "May 1, 2008"
Ditto.

It gives us a stick to ask vendors to maintain upstream versions of
driver code in the distros. 

While we are at this. I believe that there is not much of a standard for
driver versioning. If we automatically get a driver version from the
kernel version then it solves both problems. Thoughts ??

Thanks,
Shyam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help