Re: [PATCH] *icsk_ca_priv: Reduce inet_connection_sock size?
From: Evgeniy Polyakov <hidden>
Date: 2008-08-31 20:23:01
From: Evgeniy Polyakov <hidden>
Date: 2008-08-31 20:23:01
Hi Daniele. On Sun, Aug 31, 2008 at 09:19:38PM +0200, Daniele Lacamera (root@danielinux.net) wrote:
fast path? I don't think so... the modules allocate the ca_priv once per connection, at the beginning of the connection and only if that specific module needs that. Am I missing something?
That's actually a very fast path: connection establishment both for listened and connection sockets (tcp_init_congestion_control() is called for TCP_SYN_RECV state too), so you forces every socket allocation (if appropriate congestion contttrol requires that) to be doubled. This actually may be not a big problem, since we allocate and free objects all the time, but still it is additional overhead which can be avoided. Did you run some perfromance analysis to check if influence is small or not visible at all? -- Evgeniy Polyakov