On Wed, 27 Aug 2008, Pavel Emelyanov wrote:

After turning IP_XXX_STATS, TCP_XXX_STATS and NET_XXX_STATS from
macros into functions the net/ipv4/built-in.o shrank significantly:

add/remove: 14/0 grow/shrink: 0/67 up/down: 482/-2246 (-1764)

Turning the CONFIG_NET_NS option on makes this shrink even larger:

add/remove: 14/0 grow/shrink: 0/67 up/down: 478/-2646 (-2168)

Is there perhaps some DEBUG related config that could bloat these numbers?
...I didn't come up with anything obvious when I quickly looked the 
definations but I might have missed something.

So the question is - what was the reason to keep those as macros?
I thought about the possible performance questions, but netperf
didn't show any (I admit I just cannot cook it properly).

IMHO, even if there would be some performance regression, only the
most hottest paths would need to have it inlined, the rest would be
quite fine having it as a function.

--
 i.