Re: [Bugme-new] [Bug 11316] New: severe performance regression for iptables nat routing
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-08-15 10:32:49
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2008-08-15 · Re: [Bugme-new] [Bug 11316] New: severe performance regression for iptables nat routing · David Miller <davem@davemloft.net>
- 2008-08-15 · Re: [Bugme-new] [Bug 11316] New: severe performance regression for iptables nat routing · Herbert Xu <herbert@gondor.apana.org.au>
- 2008-08-15 · Re: [Bugme-new] [Bug 11316] New: severe performance regression for iptables nat routing · Alex Williamson <hidden>
- 2008-08-15 · Re: [Bugme-new] [Bug 11316] New: severe performance regression for iptables nat routing · Herbert Xu <herbert@gondor.apana.org.au>
- 2008-08-15 · Re: [Bugme-new] [Bug 11316] New: severe performance regression for iptables nat routing · Herbert Xu <herbert@gondor.apana.org.au>
On Fri, Aug 15, 2008 at 06:14:42PM +1000, Herbert Xu wrote:
It's OK, I can reproduce it now.
This fixes it for me. loopback: Enable TSO This patch enables TSO since the loopback device is naturally capable of handling packets of any size. This also means that we won't enable GSO on lo which is good until GSO is fixed to preserve netfilter state as netfilter treats loopback packets in a special way. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> I'll work on the netfilter state preservation next. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index 49f6bc0..c11e621 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c@@ -234,9 +231,7 @@ static void loopback_setup(struct net_device *dev) dev->type = ARPHRD_LOOPBACK; /* 0x0001*/ dev->flags = IFF_LOOPBACK; dev->features = NETIF_F_SG | NETIF_F_FRAGLIST -#ifdef LOOPBACK_TSO | NETIF_F_TSO -#endif | NETIF_F_NO_CSUM | NETIF_F_HIGHDMA | NETIF_F_LLTX