Re: [patch 06/12] hamradio: add missing sanity check to tty operation
From: Jeff Garzik <hidden>
Date: 2008-08-07 06:23:58
From: Jeff Garzik <hidden>
Date: 2008-08-07 06:23:58
akpm@linux-foundation.org wrote:
From: Eugene Teo <redacted> Add missing sanity check to tty operation. Acked-by: Alan Cox <redacted> Signed-off-by: Eugene Teo <redacted> Cc: Jeff Garzik <redacted> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- drivers/net/hamradio/mkiss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/net/hamradio/mkiss.c~hamradio-add-missing-sanity-check-to-tty-operation drivers/net/hamradio/mkiss.c--- a/drivers/net/hamradio/mkiss.c~hamradio-add-missing-sanity-check-to-tty-operation +++ a/drivers/net/hamradio/mkiss.c@@ -548,7 +548,7 @@ static int ax_xmit(struct sk_buff *skb, } printk(KERN_ERR "mkiss: %s: transmit timed out, %s?\n", dev->name, - (ax->tty->ops->chars_in_buffer(ax->tty) || ax->xleft) ? + (tty_chars_in_buffer(ax->tty) || ax->xleft) ? "bad line quality" : "driver error"); ax->xleft = 0;
applied