Re: [PATCH] MD5: Fix MD5 signatures on certain ACK packets

From: "Adam Langley" <redacted>
Date: Thu, 31 Jul 2008 19:56:31 -0700

I noticed, looking at tcpdumps, that timewait ACKs were getting sent with an
incorrect MD5 signature when signatures were enabled.

I broke this in 49a72dfb8814c2d65bd9f8c9c6daf6395a1ec58d. I didn't take into
account that the skb passed to tcp_*_send_ack was the inbound packet, thus the
source and dest addresses need to be swapped when calculating the MD5
pseudoheader.

Signed-off-by: Adam Langley <redacted>

Applied.

But please provide commit header line text when referencing SHA IDs.
Here is the final fixed up commit message I used when applying this.

    tcp: MD5: Fix MD5 signatures on certain ACK packets
    
    I noticed, looking at tcpdumps, that timewait ACKs were getting sent
    with an incorrect MD5 signature when signatures were enabled.
    
    I broke this in 49a72dfb8814c2d65bd9f8c9c6daf6395a1ec58d ("tcp: Fix
    MD5 signatures for non-linear skbs"). I didn't take into account that
    the skb passed to tcp_*_send_ack was the inbound packet, thus the
    source and dest addresses need to be swapped when calculating the MD5
    pseudoheader.
    
    Signed-off-by: Adam Langley [off-list ref]