Re: [PATCH 2/7] drivers/net/ehea/ehea_main.c: Release mutex in error handling code
From: Jeff Garzik <hidden>
Date: 2008-07-30 21:24:20
Also in:
kernel-janitors, lkml
From: Jeff Garzik <hidden>
Date: 2008-07-30 21:24:20
Also in:
kernel-janitors, lkml
Julia Lawall wrote:
From: Julia Lawall <redacted> The mutex is released on a successful return, so it would seem that it should be released on an error return as well. The semantic patch finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression l; @@ mutex_lock(l); ... when != mutex_unlock(l) when any when strict ( if (...) { ... when != mutex_unlock(l) + mutex_unlock(l); return ...; } | mutex_unlock(l); ) // </smpl> Signed-off-by: Julia Lawall <redacted>
applied