Thread (2 messages) 2 messages, 2 authors, 2008-07-30

Re: [patch nacked? 2/4] 3c59x: fix PCI resource management

From: Steffen Klassert <hidden>
Date: 2008-07-30 22:10:45

On Wed, Jul 30, 2008 at 12:40:47PM -0700, akpm@linux-foundation.org wrote:
From: Sergei Shtylyov <redacted>

The driver wrongly claimed I/O ports at an address returned by pci_iomap()
-- even if it was passed an MMIO address.  Fix this by claiming/releasing
all PCI resources in the PCI driver probe/remove handlers instead and get
rid of the must_free_region flag weirdness (why would Cardbus claim
anything for us?).

Also, the remove handler was trying to talk to the chip after having
disabled its address decoders (at least on x86) -- fix this and get rid of
useless VORTEX_PCI() calls.

While at it, fix some cases of the overly indented code...
The compile error of that patch should be fixed by git commit
0da0ead90122578ef6e4afba9ba4bcd3455fd8e8 at least.

I'll take this one and look at it.

Steffen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help