Thread (2 messages) 2 messages, 2 authors, 2008-07-30

Re: [PATCH] ipt_recent: fix race between recent_mt_destroy and proc manipulations

From: Patrick McHardy <hidden>
Date: 2008-07-30 10:52:53
Also in: netfilter-devel

Pavel Emelyanov wrote:
The thing is that recent_mt_destroy first flushes the entries
from table with the recent_table_flush and only *after* this
removes the proc file, corresponding to that table.

Thus, if we manage to write to this file the '+XXX' command we
will leak some entries. If we manage to write there a 'clean'
command we'll race in two recent_table_flush flows, since the
recent_mt_destroy calls this outside the recent_lock.

The proper solution as I see it is to remove the proc file first
and then go on with flushing the table. This flushing becomes
safe w/o the lock, since the table is already inaccessible from
the outside.
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help