Thread (11 messages) 11 messages, 4 authors, 2008-08-01

Re: [PATCH] IPVS: Move userspace definitions to include/linux/ip_vs.h

From: Simon Horman <horms@verge.net.au>
Date: 2008-07-25 00:18:58
Also in: lvs-devel

On Thu, Jul 24, 2008 at 01:46:38PM +0200, Julius Volz wrote:
On Thu, Jul 24, 2008 at 1:40 PM, Patrick McHardy [off-list ref] wrote:
quoted
Julius Volz wrote:
quoted
On Thu, Jul 24, 2008 at 1:22 PM, Patrick McHardy [off-list ref] wrote:
quoted
quoted
quoted
+/* Move it to better place one day, for now keep it unique */
+#define NFC_IPVS_PROPERTY      0x10000
Does this have any connection to the skb flag? If so, does
it really belong in the userspace interface?
This doesn't seem to be used at all anymore, but I didn't want to
remove it in the same patch... should I?
I'm not sure if this is (or has been) used by userspace, someone
more familiar with IPVS should answer that.
I don't think so. It was once used as a bitmask into skb->nfcache,
which does not even exist anymore. There's no use of it in the current
ipvsadm. I think it can go away, I'll post an updated patch again.
I'm pretty sure that it is safe to get rid of NFC_IPVS_PROPERTY

-- 
Horms
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help