Re: [PATCH 1/2] 8139too: Make PIO/MMIO a modparam
From: Dave Jones <hidden>
Date: 2008-07-15 23:48:26
From: Dave Jones <hidden>
Date: 2008-07-15 23:48:26
On Tue, Jul 15, 2008 at 07:31:16PM -0400, Jeff Garzik wrote: > Sorry for not being specific. I would have guessed the uglier > > #ifdef CONFIG_8139TOO_PIO > static int use_io = 1; > #else > static int use_io; > #endif > > since CONFIG_8139TOO_PIO doesn't convert to a 1 or 0 neatly in C AFAIK? Hm, yeah. that only works in the PIO=1 case. When not set, it doesn't end up in autoconf.h. I'll go with the fugly ifdefs. Dave -- http://www.codemonkey.org.uk