Thread (1 message) 1 message, 1 author, 2008-07-11

Re: [PATCH RESEND] dm9601: don't do usb transfers of data on stack

From: Peter Korsgaard <hidden>
Date: 2008-07-11 12:55:55

quoted
quoted
quoted
quoted
"Oliver" == Oliver Neukum [off-list ref] writes:
Hi,

 >> Ahh. So kmalloc() / kfree() around the usb_control_msg isn dm_read /
 >> dm_write is the way to go?

 Oliver> The buffer should be allocated with kmalloc. That doesn't
 Oliver> mean it has to be allocated each time the function is
 Oliver> called. If several drivers do this, the best fix is to modify
 Oliver> struct usbnet so that it contains only a pointer to the
 Oliver> buffer, not the buffer itself and modify drivers accordingly.

Ok, but this is just for a few config registers - Nothing in the fast
path, so I'll keep it simple.

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help