[PATCH V2] ibm_newemac: Fixes kernel crashes when speed of cable connected changes
From: Stefan Roese <sr@denx.de>
Date: 2008-06-23 18:36:16
Also in:
linuxppc-dev
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
From: Sathya Narayanan <redacted> The descriptor pointers were not initialized to NIL values, so it was poiniting to some random addresses which was completely invalid. This fix takes care of initializing the descriptor to NIL values and clearing the valid descriptors on clean ring operation. Signed-off-by: Sathya Narayanan <redacted> Signed-off-by: Stefan Roese <sr@denx.de> --- Changed since V1: - Fixed off-by-one error in for loops drivers/net/ibm_newemac/core.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index 5d2108c..6dfc2c9 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c@@ -1025,7 +1025,7 @@ static void emac_clean_tx_ring(struct emac_instance *dev) int i; for (i = 0; i < NUM_TX_BUFF; ++i) { - if (dev->tx_skb[i]) { + if (dev->tx_skb[i] && dev->tx_desc[i].data_ptr) { dev_kfree_skb(dev->tx_skb[i]); dev->tx_skb[i] = NULL; if (dev->tx_desc[i].ctrl & MAL_TX_CTRL_READY)
@@ -2719,6 +2719,10 @@ static int __devinit emac_probe(struct of_device *ofdev, /* Clean rings */ memset(dev->tx_desc, 0, NUM_TX_BUFF * sizeof(struct mal_descriptor)); memset(dev->rx_desc, 0, NUM_RX_BUFF * sizeof(struct mal_descriptor)); + for (i = 0; i < NUM_TX_BUFF; i++) + dev->tx_skb[i] = NULL; + for (i = 0; i < NUM_RX_BUFF; i++) + dev->rx_skb[i] = NULL; /* Attach to ZMII, if needed */ if (emac_has_feature(dev, EMAC_FTR_HAS_ZMII) &&
--
1.5.6