Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()
From: Matvejchikov Ilya <hidden>
Date: 2008-06-18 18:45:58
Also in:
linuxppc-dev
I'm glad that you have corrected it. Half a year ago I pointed out that there was such a mistake: http://patchwork.ozlabs.org/linuxppc/patch?id=10700 Thanks. 2008/6/18 Laurent Pinchart [off-list ref]:
quoted hunk ↗ jump to hunk
The restart() function is called when the link state changes and resets multicast and promiscous settings. This patch restores those settings at the end of restart(). Signed-off-by: Laurent Pinchart <redacted> --- drivers/net/fs_enet/mac-fcc.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletions(-)diff --git a/drivers/net/fs_enet/mac-fcc.c b/drivers/net/fs_enet/mac-fcc.c index ce40cf9..1a95cf1 100644 --- a/drivers/net/fs_enet/mac-fcc.c +++ b/drivers/net/fs_enet/mac-fcc.c@@ -464,6 +464,9 @@ static void restart(struct net_device *dev) C32(fccp, fcc_fpsmr, FCC_PSMR_FDE | FCC_PSMR_LPB); S32(fccp, fcc_gfmr, FCC_GFMR_ENR | FCC_GFMR_ENT); + + /* Restore multicast and promiscous settings */ + set_multicast_list(dev); } static void stop(struct net_device *dev) --1.5.0 -- Laurent Pinchart CSE Semaphore Belgium Chaussee de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 F +32 (2) 387 42 75