Re: [PATCH 8/13] r8169: Tx performance tweak
From: Ben Hutchings <hidden>
Date: 2008-06-30 10:54:20
Francois Romieu wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com> Cc: Edward Hsu <redacted> --- drivers/net/r8169.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index c2861a4..46bdcb9 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c@@ -2156,19 +2156,19 @@ static void rtl_hw_start_8169(struct net_device *dev) RTL_W16(IntrMask, tp->intr_event); } -static void rtl8168_tx_performance_tweak(struct pci_dev *pdev, unsigned int reg -) +static void rtl8168_tx_performance_tweak(struct pci_dev *pdev, + unsigned int reg, u8 force) { u8 ctl; pci_read_config_byte(pdev, reg, &ctl); - ctl = (ctl & ~0x70) | 0x50; + ctl = (ctl & ~0x70) | force; pci_write_config_byte(pdev, reg, ctl);
[...] This would be a lot more understandable if you used pci_find_capability() and the named constants from <linux/pci_regs.h>: #define PCI_EXP_DEVCTL 8 /* Device Control */ #define PCI_EXP_DEVCTL_NOSNOOP_EN 0x0800 /* Enable No Snoop */ #define PCI_EXP_DEVCTL_READRQ 0x7000 /* Max_Read_Request_Size */ Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job.