Re: [PATCH v2] net/inet_lro: remove setting skb->ip_summed when not LRO-able
From: David Miller <davem@davemloft.net>
Date: 2008-06-28 03:09:15
From: David Miller <davem@davemloft.net>
Date: 2008-06-28 03:09:15
From: Eli Cohen <redacted> Date: Wed, 25 Jun 2008 18:29:12 +0300
When an SKB cannot be chained to a session, the current code attempts to "restore" its ip_summed field from lro_mgr->ip_summed. However, lro_mgr->ip_summed does not hold the original value; in fact, we'd better not touch skb->ip_summed since it is not modified by the code in the path leading to a failure to chain it. Also use a cleaer comment to the describe the ip_summed field of struct net_lro_mgr. Issue raised by Or Gerlitz [off-list ref] Signed-off-by: Eli Cohen <redacted>
Patch applied, thanks everyone.