Re: [PATCH] TCP MD5 and TSO/SG breakage
From: Adam Langley <hidden>
Date: 2008-06-27 18:28:16
From: Adam Langley <hidden>
Date: 2008-06-27 18:28:16
On Fri, Jun 27, 2008 at 11:21 AM, Stephen Hemminger [off-list ref] wrote:
The TCP MD5 support is broken on any device that does scatter gather. The MD5 calculation code doesn't support scatter/gather, the md5_calc API assumes the data follows the TCP header. It is too late to rework this code for 2.6.26 (and backport to stable). So the sane thing to do is block use of SG on TCP sockets using MD5 option.
Acked-By: Adam Langley <redacted> AGL -- Adam Langley agl@imperialviolet.org http://www.imperialviolet.org