Thread (6 messages) 6 messages, 3 authors, 2008-06-27

Re: [PATCH 2/4] e1000: add module option to set transmit descriptor size

From: Arthur Jones <hidden>
Date: 2008-06-27 14:30:30

Hi Jeff, ...

On Thu, Jun 26, 2008 at 10:10:37PM -0700, Jeff Garzik wrote:
Andy Gospodarek wrote:
quoted
This patch added the TxDescPower parameter to the e1000 module.  This
parameter represents the size-order of each transmit descriptor.  The
valid size for descriptors would be 2^7 (128) - 2^12 (4096) bytes each.
As this value decreases one may want to consider increasing the
TxDescriptors value to maintain the same amount of frame memory.  This
patch does not change the defaults for any particular hardware model, so
this will not have an effect on existing users.
[...]
I don't see why a module parameter is needed.  In practice, nobody will
ever think about this option, much less use it.
I would use it.  I see this issue on some
interfaces and not others due to different
traffic patterns.  A module parameter or sysfs
entry would be a huge help for me -- right now,
I have to recompile the driver which is difficult
to deploy...

So for the patch itself:

Acked-by: Arthur Jones <redacted>

Arthur
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help