Re: [PATCH 01/10] smc91x: remove unused code enclosed by #ifdef CONFIG_ISA .. #endif
From: Eric Miao <hidden>
Date: 2008-06-27 06:10:57
From: Eric Miao <hidden>
Date: 2008-06-27 06:10:57
Jeff Garzik wrote:
Eric Miao wrote:quoted
Apparently, the code enclosed by #ifdef CONFIG_ISA .. #endif are no longer usedWhat does this mean? CONFIG_ISA platforms still exist, and one presumes that the ISA hardware still exists. Is this hardware covered by another driver?
Well, I assume the original code tends to support ISA with module parameters to setup the IO address base and IRQ etc. But obviously, those part of the code is now totally invalid and confusing only. Should there be requirement of supporting ISA hardware with this chip, the driver is actually unable to, and I prefer to re-write that part of the code if necessary. BTW: I don't know any ISA NIC with a SMC91X chip by far, and I cannot infer by the driver code itself what type of ISA NIC it is supporting.