Thread (4 messages) 4 messages, 3 authors, 2008-06-27

Re: [PATCH 1/4] e1000: disable TSO workaround on 82544

From: Jeff Kirsher <hidden>
Date: 2008-06-25 08:50:43

On Thu, Jun 19, 2008 at 2:18 PM, Andy Gospodarek [off-list ref] wrote:
quoted hunk ↗ jump to hunk
It appears that the 82544 does not need the TSO workaround needed on
other chips.  This seems to resolve excessive messages that appear to be
Tx Unit Hangs when a system is under heavy stress.

Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
---
 drivers/net/e1000/e1000_main.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 59579b1..af6846d 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -3479,7 +3479,8 @@ e1000_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
       }

       if (likely(tso)) {
-               tx_ring->last_tx_tso = 1;
+               if (likely(adapter->hw.mac_type != e1000_82544))
+                       tx_ring->last_tx_tso = 1;
               tx_flags |= E1000_TX_FLAGS_TSO;
       } else if (likely(e1000_tx_csum(adapter, tx_ring, skb)))
               tx_flags |= E1000_TX_FLAGS_CSUM;
--
1.5.2.1
ACK - patches 1-4
Signed-off-by: Jeff Kirsher <redacted>

-- 
Cheers,
Jeff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help