On Mon, Jun 23, 2008 at 12:50:30PM +0300, Octavian Purdila wrote:

On Monday 23 June 2008, Jarek Poplawski wrote:

...

quoted

But, I think it's better to separate the change of functionality (a
recursive processing of frag_list) to another patch (if there is a
practical reason for this).

Yes, it makes sense, I'll remove the recursion from this patch. 

About the recursion: don't know if it makes a difference from a functional 
perspective (I don't think that we can have frag_lists in frag_lists), but 
I've noticed that skb_copy_bits does recurse. Any idea why?

I meant it's potentially the change of functionality in this place.
Probably this recursion is intended for 1 level only, and is natural
in this place. But, since this place didn't use this, it should be
safer to separate this change to another patch (of course, consistency
with skb_copy_bits could be a good argument).

Jarek P.