Re: [PATCH] IRDA: Fix genlmsg_put() return value check.
From: Julius Volz <hidden>
Date: 2008-06-23 20:29:15
On Mon, Jun 23, 2008, Patrick McHardy wrote:
Good catch, but the correct return value for insufficient space in the skb is -ENOSPC.
Hm, seems we have many inconsistent values returned in exactly this situation (in response to genlmsg_put), but none of them are -ENOSPC: fs/dlm/netlink.c: -EINVAL net/netlink/genetlink.c: -1 net/netlabel/netlabel_unlabeled.c: -ENOMEM net/netlabel/netlabel_cipso_v4.c: -ENOMEM net/netlabel/netlabel_mgmt.c: -ENOMEM net/wireless/nl80211.c: -1 drivers/acpi/event.c: -ENOMEM kernel/taskstats.c: -EINVAL Seems like -ENOMEM is most common, don't know if that means it's correct, though... I was also using -ENOMEM in my Netlink code, so better convert all my new uses to -ENOSPC? Julius -- Google Switzerland GmbH