Thread (7 messages) 7 messages, 4 authors, 2008-06-28

RE: [2.6 patch] remove CONFIG_NET_SCH_RR

From: Waskiewicz Jr, Peter P <hidden>
Date: 2008-06-23 18:31:36

Commit d62733c8e437fdb58325617c4b3331769ba82d70
([SCHED]: Qdisc changes and sch_rr added for multiqueue)
added a NET_SCH_RR option that was unused since the code
went unconditionally into sch_prio.
I don't agree we should remove this option, purely for the fact that
there isn't any way a user would know the qdisc existed without reading
the code.  I'd rather see a change to sch_prio.c to correctly wrap the
RR code, which I should have done in the first place.  My hurdle is when
the module is selected, NET_SCH_RR isn't defined to be used as an #ifdef
check in the code.  Only when it's selected to be built-in is the symbol
defined.  If I can get around that, I'll generate a patch to properly
wrap sch_prio.c code.  I know I'm missing something silly, so any
guidance is appreciated.

-PJ Waskiewicz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help