Thread (7 messages) 7 messages, 3 authors, 2008-06-28

Re: [PATCH] ax25.h unsigned long type for ax25 timers

From: Bernard Pidoux <hidden>
Date: 2008-06-19 16:28:46
Also in: linux-hams

David,

Unfortunately I don't quite understand exactly why a structure in user 
space cannot be changed.
But this means that I have to make some effort to learn a bit more about 
the kernel structure and userspace.
However, thank you for your explanation about how to fix the discrepancy 
between both timer structures.
I will try to dig out more information on this subject.

Bernard Pidoux, f6bvp
 

David Miller a écrit :
From: Bernard Pidoux <redacted>
Date: Tue, 17 Jun 2008 15:04:38 +0200

  
quoted
In linux/include/linux/ax25.h
ax25_info_struct timers types remain unsigned

struct ax25_info_struct {
	unsigned int	n2, n2count;
	unsigned int	t1, t1timer;
	unsigned int	t2, t2timer;
	unsigned int	t3, t3timer;
	unsigned int	idle, idletimer;
        .....
};

while in linux/include/net/ax25.h timers are unsigned long according
to kernel 2.6 timers.

typedef struct ax25_cb {
        .....
        struct timer_list       t1timer, t2timer, t3timer, idletimer;
        unsigned long           t1, t2, t3, idle, rtt;
        ....

Although ax25_info_struct is not much used it is refered at least
into libax25 and xfbb BBS application program.

It seems thus reasonable to make the change.

Signed-off-by: Bernard Pidoux <redacted>
    
Unfortunately this datastructure is exported to userspace,
and therefore we cannot change the structure layout without
breaking userspace.

We cannot, as a result, make this change.

The only way to fix this is to make a new fixed structure, and add new
ax25 calls that accept this new structure.


  
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help