Thread (12 messages) 12 messages, 4 authors, 2008-06-14

Re: [PATCH 1/3] virtio: fix virtio_net xmit of freed skb bug

From: Jeff Garzik <hidden>
Date: 2008-05-31 02:12:41

Rusty Russell wrote:
If we fail to transmit a packet, we assume the queue is full and put
the skb into last_xmit_skb.  However, if more space frees up before we
xmit it, we loop, and the result can be transmitting the same skb twice.

Fix is simple: set skb to NULL if we've used it in some way, and check
before sending.

Signed-off-by: Rusty Russell <redacted>
---
 drivers/net/virtio_net.c |   14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)
applied 1-2 (#3 was already applied)

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help