Re: [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled
From: Adam Langley <hidden>
Date: 2008-05-30 19:11:45
On Fri, May 30, 2008 at 12:02 PM, Ben Hutchings [off-list ref] wrote:
Putting an #ifdef..#endif in the middle of an if () is a bit nasty. Why not define md5 and set it to 0 if CONFIG_TCP_MD5SIG is not set? The compiler should be able to optimise it away if it's always initialised to 0.
That's a good point, thanks. Followup patch in a second... AGL -- Adam Langley agl@imperialviolet.org http://www.imperialviolet.org