Re: [PATCH 01/01] smsc911x: fix MAC addresssetting after reset
From: Hennerich, Michael <hidden>
Date: 2008-05-19 13:15:25
Steve, I'd love to see this one merged. -Michael ________________________________ From: Steve.Glendinning-sdUf+H5yV5I@public.gmane.org [mailto:Steve.Glendinning-sdUf+H5yV5I@public.gmane.org] Sent: Montag, 19. Mai 2008 14:33 To: Hennerich, Michael Cc: bahadir.balban-5wv7dgnIgG8@public.gmane.org; bgat-uPd5UNENI//N9NzbbXoYwQ@public.gmane.org; Enrik Berkhan; hennerich-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org; Ian.Saturley-sdUf+H5yV5I@public.gmane.org; uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org; catalin.marinas-5wv7dgnIgG8@public.gmane.org; netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: RE: [Uclinux-dist-devel] [PATCH 01/01] smsc911x: fix MAC addresssetting after reset Hi Michael, I've been maintaining the smsc911x driver out-of-tree, I'll send my latest full patch following this email. Bill Gatliff already fixed the same MAC address issue, and I've added support for the new LAN9210 and LAN9211 devices. (adding netdev to cc) I'd still like to see this driver replace smc911x in mainline, how does everyone else feel? Regards, -- Steve Glendinning SMSC GmbH m: +44 777 933 9124 e: steve.glendinning-sdUf+H5yV5I@public.gmane.org "Hennerich, Michael" [off-list ref] 16/05/2008 11:58 To "Enrik Berkhan" [off-list ref], Steve Glendinning/SMSC@SMSC cc [off-list ref], Ian Saturley/SMSC@SMSC, [off-list ref], [off-list ref], [off-list ref] Subject RE: [Uclinux-dist-devel] [PATCH 01/01] smsc911x: fix MAC addresssetting after reset Hi Steve, I received a patch to address the MAC address soft reset issue, discussed before. Is there a newer driver with this and maybe other fixes? Some time ago I thought this driver is going to be mainlined. Are you still panning to get it merged, - replace smc911x.c. -Michael
-----Original Message----- From: uclinux-dist-devel-bounces-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org
[mailto:uclinux-dist-
quoted hunk
devel-bounces-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org] On Behalf Of Enrik Berkhan Sent: Donnerstag, 15. Mai 2008 19:08 To: uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org Subject: [Uclinux-dist-devel] [PATCH 01/01] smsc911x: fix MAC addresssetting after reset The SMSC911X driver soft-resets the chip on open(). This makes the chip forget and re-load its MAC address from its EEPROM, if avail- able. If the MAC address has been set externally (e. g. by the bootloader or via command line), this setting is lost. This patch fixes the problem by always setting the saved MAC address after soft reset. Signed-Off-By: Enrik Berkhan <redacted> --- drivers/net/smsc911x.c | 4 ++++ 1 file changed, 4 insertions(+) Index: drivers/net/smsc911x.c ===================================================================--- drivers/net/smsc911x.c.orig 2008-05-15
18:49:30.000000000 +0200
quoted hunk
+++ drivers/net/smsc911x.c 2008-05-15
18:51:28.000000000 +0200
quoted hunk
@@ -1182,6 +1182,10 @@ static int smsc911x_open(struct net_devi udelay(10); } + /* Set MAC again in case it has been set from
non-EEPROM source
+ * (config or even bootloader) */
+ smsc911x_set_mac_address(pdata, dev->dev_addr);
+
if (unlikely(timeout == 0)) {
SMSC_WARNING("Timed out waiting forEEPROM "
"busy bit to
clear");
_______________________________________________ Uclinux-dist-devel mailing list Uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org http://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel