Re: [PATCH][NET_SCHED] sch_sfq: prevent unnecessary reordering
From: David Miller <davem@davemloft.net>
Date: 2008-04-28 09:03:56
From: David Miller <davem@davemloft.net>
Date: 2008-04-28 09:03:56
From: Jarek Poplawski <redacted> Date: Mon, 28 Apr 2008 09:04:53 +0000
On 27-04-2008 16:22, Jarek Poplawski wrote:quoted
[NET_SCHED] sch_sfq: fix queue limiting while enqueuingDavid, as Patrick noticed this patch was wrong and I withdraw it.
Yes, I was following the discussion. But thanks for the confirmation :-)
I still can't see why sfq should have such a low limit, but I think, there is at least something to improve in the way it's imposed. BTW, my previous idea to check this before classifying was wrong too. But, IMHO, this could be done better than now like in this patch.
...
[NET_SCHED] sch_sfq: prevent unnecessary reordering Current check of queue limit in sfq_enqueue() isn't optimal: there is really not much more needed to prevent unnecessary dropping and possible reordering. Signed-off-by: Jarek Poplawski <redacted>
I'll let Patrick review this one first, too.