Hello,

On Mon, 28 Apr 2008, Simon Horman wrote:

On Mon, Apr 28, 2008 at 10:52:38AM +0300, Julian Anastasov wrote:

quoted

	Fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=10556
where conn templates with protocol=IPPROTO_IP can oops backup box.

        Result from ip_vs_proto_get() should be checked because
protocol value can be invalid or unsupported in backup. But
for valid message we should not fail for templates which use
IPPROTO_IP. Also, add checks to validate message limits and
connection state. Show state NONE for templates using IPPROTO_IP.

Julian, am I right in thinking that this is a long-standing bug
rather than a recent regression?

	Bug reporter is using 2.6.24.4, bug comes with 2.6.24,
pp is NULL for IPPROTO_IP, 2.6.24 shows:

[IPVS]: use proper timeout instead of fixed value

-               cp->timeout = IP_VS_SYNC_CONN_TIMEOUT;
+               cp->state = ntohs(s->state);
+               pp = ip_vs_proto_get(s->protocol);
+               cp->timeout = pp->timeout_table[cp->state];

Regards

--
Julian Anastasov [off-list ref]