Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver

[PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver · Sebastian Siewior <bigeasy@linutronix.de> · 2008-03-27
[PATCH / RFC 2/2] fec: fixup spinlocks. · Sebastian Siewior <bigeasy@linutronix.de> · 2008-03-27
Re: [PATCH / RFC 2/2] fec: fixup spinlocks. · Greg Ungerer <hidden> · 2008-03-28
Re: [PATCH / RFC 2/2] fec: fixup spinlocks. · Sebastian Siewior <bigeasy@linutronix.de> · 2008-03-28
Re: [PATCH / RFC 2/2] fec: fixup spinlocks. · Greg Ungerer <hidden> · 2008-03-28
[PATCH / RFC 1/2] fec: kill warnings · Sebastian Siewior <bigeasy@linutronix.de> · 2008-03-27
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver · Greg Ungerer <hidden> · 2008-03-28
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver · Sebastian Siewior <bigeasy@linutronix.de> · 2008-04-02
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver · Greg Ungerer <hidden> · 2008-04-02
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver · Jeff Garzik <hidden> · 2008-03-29
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver · Jeff Garzik <hidden> · 2008-03-29
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver · Sebastian Siewior <hidden> · 2008-04-02

From: Jeff Garzik <hidden>
Date: 2008-03-29 02:21:09

Sebastian Siewior wrote:

I got into this after turning on spinlock debugging.

Jeff: The dev->hard_start_xmit callback is always called from softirq
context so it is save to use spin_lock_irq(), right?

Greg: The isr (fec_enet_rx()) calls three functions. All
but fec_enet_rx() are grabbing the spinlock. Is this on purpose?

wanted for 2.6.25?  ACKs from maintainer?

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help