Thread (13 messages) 13 messages, 3 authors, 2008-03-29

Re: [RFC] [NET] [0/2] pskb_expand_head() bugfix

From: Hideo AOKI <hidden>
Date: 2008-03-29 01:14:30

Hello,

David Miller wrote:
From: Hideo AOKI <redacted>
Date: Wed, 26 Mar 2008 16:47:35 -0400
quoted
I think that it is inconvenient for caller functions to need
updateing truesize by themselves.
Most cases what I can see are in spots where skb->truesize
cannot be modified because the SKB is possibly charged
to a socket.

In these limited situations where skb->truesize adjustments
really are needed, and legal, it is no harm to open code
things.
Thank you for the comments.

I understood that updating truesize by caller wasn't problem.
And, I may misunderstand the spots where truesize can't be changed.

Then, I make patch to update truesize for each network subsystem and
ask a review of the patch. 

Best regards,
Hideo

--
Hitachi Computer Products (America) Inc.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help