Thread (8 messages) 8 messages, 3 authors, 2008-03-31

Re: [patch 1/4] drivers/atm/firestream.c: suppress uninitialized var warning

From: David Miller <davem@davemloft.net>
Date: 2008-03-28 23:58:12

From: Andrew Morton <akpm@linux-foundation.org>
Date: Fri, 28 Mar 2008 16:54:37 -0700
quoted
diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c
index 47c57a4..98099f5 100644
--- a/drivers/atm/firestream.c
+++ b/drivers/atm/firestream.c
@@ -978,6 +978,7 @@ static int fs_open(struct atm_vcc *atm_vcc)
 		/* Docs are vague about this atm_hdr field. By the way, the FS
 		 * chip makes odd errors if lower bits are set.... -- REW */
 		tc->atm_hdr =  (vpi << 20) | (vci << 4); 
+		tmc0 = 0;
 		{
 			int pcr = atm_pcr_goal (txtp);
Whereas the reader doesn't know why that unneeded initialisation is there.
git show $(git blame drivers/atm/firestream.c | grep "tmc0 = 0" | \
	   awk ' { print $1 } ')
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help