Thread (7 messages) 7 messages, 4 authors, 2008-04-01

Re: [UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list

From: David Miller <davem@davemloft.net>
Date: 2008-03-26 07:16:47
Also in: linux-um

From: Patrick McHardy <redacted>
Date: Wed, 26 Mar 2008 07:13:51 +0100
Jeff Garzik wrote:
quoted
quoted
 static void uml_net_set_multicast_list(struct net_device *dev)
 {
-    if (dev->flags & IFF_PROMISC)
-        return;
-    else if (dev->mc_count)
-        dev->flags |= IFF_ALLMULTI;
-    else dev->flags &= ~IFF_ALLMULTI;
+    return;
 }


Might as well just delete the hook at that point...

I kept it so SIOCADDMULTI/SIOCDELMULTI ioctls continue to
work on UML devices. I don't know if any userspace applications
check for errors when using these ioctls, this way nothing
can break.
Good idea, patch applied to net-2.6, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help