Re: [PATCH] virtio_net/virtio_ring: fix race in enable_cb

On Monday 17 March 2008 17:30:44 Christian Borntraeger wrote:

quoted

Are you seeing the "Unlikely: restart svq failed" message in the logs? 
If not, I don't think it can be this race.

No, I dont see the message, but this message only happens for guest->host
traffic in the xmit function.

Interesting you don't see this.  Or is it just on that load that you don't see 
it?

I was fixing the poll function - which has no 
printk.
I added the disable_cb in the xmit function only  to adopt to changed
enable_cb semantics.

I double checked my theory with a printk in enable_cb. The more_used check
was true several times for the receiving virtqueue.

Excellent, thanks.

I applied your patch, and have asked Linus to pull that and my other qeued 
virtio fixes.

Cheers,
Rusty.