Re: [PATCH/RFC] introduce ARCH_CAN_UNALIGNED_ACCESS Kconfig symbol

On Thu, 2008-03-20 at 14:39 +0000, Will Newton wrote:

On Thu, Mar 20, 2008 at 2:34 PM, Johannes Berg
[off-list ref] wrote:

quoted

 +For some ethernet hardware that cannot DMA to unaligned addresses like
 +4*n+2 or non-ethernet hardware, this can be a problem, and it is then
 +required to copy the incoming frame into an aligned buffer. Because this is
 +unnecessary on architectures that can do unaligned accesses, the code can be
 +made depend on CONFIG_ARCH_CAN_UNALIGNED_ACCESS like so:
 +
 +#ifdef CONFIG_ARCH_CAN_UNALIGNED_ACCESS
 +       skb = copy skb
 +#else
 +       skb = original skb
 +#endif

Is this logic reversed?

Euh, indeed, thanks. Will repost after having more comments.

johannes