Re: [PATCHv2] [XFRM]: Speed up xfrm_policy and xfrm_state walking
From: David Miller <davem@davemloft.net>
Date: 2008-02-29 05:31:49
From: David Miller <davem@davemloft.net>
Date: 2008-02-29 05:31:49
From: Timo_Teräs <redacted> Date: Fri, 15 Feb 2008 20:22:54 +0200
Change xfrm_policy and xfrm_state walking algorithm from O(n^2) to O(n). This is achieved adding the entries to one more list which is used solely for walking the entries. This also fixes some races where the dump can have duplicate or missing entries when the SPD/SADB is modified during an ongoing dump. Dumping SADB with 20000 entries using "time ip xfrm state" the sys time dropped from 1.012s to 0.080s. Signed-off-by: Timo Teras <redacted>
Applied, although this will make add/delete slightly slower. Could you do that AF_KEY dumping patch you talked about? I change my mind, we can do it. THanks.