Thread (8 messages) 8 messages, 5 authors, 2008-03-09

Re: [PATCH][AX25] ax25_route: make ax25_route_lock BH safe

From: David Miller <davem@davemloft.net>
Date: 2008-02-12 05:26:27

From: Jarek Poplawski <redacted>
Date: Mon, 11 Feb 2008 12:42:51 +0000
[AX25] ax25_route: make ax25_route_lock BH safe
quoted
=================================
[ INFO: inconsistent lock state ]
2.6.24-dg8ngn-p02 #1
---------------------------------
inconsistent {softirq-on-W} -> {in-softirq-R} usage.
linuxnet/3046 [HC0[0]:SC1[2]:HE1:SE0] takes:
 (ax25_route_lock){--.+}, at: [<f8a0cfb7>] ax25_get_route+0x18/0xb7 [ax25]
{softirq-on-W} state was registered at:
...

This lockdep report shows that ax25_route_lock is taken for reading in
softirq context, and for writing in process context with BHs enabled.
So, to make this safe, all write_locks in ax25_route.c are changed to
_bh versions.


Reported-by: Jann Traschewski <redacted>,
Signed-off-by: Jarek Poplawski <redacted>
Applied, thanks a lot Jarek.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help