Thread (7 messages) 7 messages, 3 authors, 2008-02-05

Re: Still oopsing in nf_nat_move_storage()

From: Patrick McHardy <hidden>
Date: 2008-02-02 10:26:27
Also in: netfilter-devel

Chuck Ebbert wrote:
On 01/31/2008 01:03 PM, Chuck Ebbert wrote:
quoted
On 01/29/2008 12:18 PM, Patrick McHardy wrote:
quoted
Chuck Ebbert wrote:
quoted
nf_nat_move_storage():
/usr/src/debug/kernel-2.6.23/linux-2.6.23.i686/net/ipv4/netfilter/nf_nat_core.c:612

      87:       f7 47 64 80 01 00 00    testl  $0x180,0x64(%edi)
      8e:       74 39                   je     c9
<nf_nat_move_storage+0x65>

line 612:
        if (!(ct->status & IPS_NAT_DONE_MASK))
                return;

ct is NULL
The current kernel (and 2.6.23-stable) have:

        if (!ct || !(ct->status & IPS_NAT_DONE_MASK))
                return;

so it seems you're using an old version.
So, it is now oopsing after the test for NULL and only x86_64 is
catching the invalid address because it is non-canonical. Checking
for NULL is obviously not enough...

The addresses passed to ->move seems to be bogus, we're doing:

           t->move(ct, ct->ext + ct->ext->offset[i]);

without assigning the new ct->ext first, which is wrong for
two reasons:

- the new ext hasn't been assigned to the conntrack yet,
   so its moving within the same extension

- ct->ext + ct->ext->offset[i] should be (void *)ct->ext + ...

I'll fix it and send a patch after some testing. Still wondering
why this wasn't noticed before.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help