On Wednesday 27 February 2008 4:55:43 pm Adrian Bunk wrote:

On Wed, Feb 27, 2008 at 04:42:57PM -0500, Paul Moore wrote:

quoted

On Wednesday 27 February 2008 4:20:42 pm Adrian Bunk wrote:

quoted

Every file should include the headers containing the externs for
its global code.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

It doesn't _need_ the file in the strictest sense, the header file
is just there for the core SELinux code to call into the
NetLabel/SELinux glue code (what is in
security/selinux/netlabel.c).  However, if this is to conform
better to kernel coding policy (I assume that is the case here?)
then that is fine with me.

I'm not claiming it needs it.

But with this #include gcc can check that the prototypes in
netlabel.h match the functions in netlabel.c

The bugs this catches are rare, but when you have such a bug it can
be nasty to debug.

Good point, hadn't thought of that - thanks.  

quoted

Acked-by: Paul Moore <redacted>

-- 
paul moore
linux security @ hp