Thread (1 message) 1 message, 1 author, 2008-02-11

Re: [PATCH] Execute tasklets in the same order they were queued

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2008-02-11 22:50:42
Also in: lkml

On Mon, 11 Feb 2008 16:28:13 -0600
Olof Johansson [off-list ref] wrote:
I noticed this when looking at an openswan issue. Openswan (ab?)uses
the tasklet API to defer processing of packets in some situations,
with one packet per tasklet_action(). I started noticing sequences of
reverse-ordered sequence numbers coming over the wire, since new tasklets
are always queued at the head of the list but processed sequentially.

Convert it to instead append new entries to the tail of the list. As an
extra bonus, the splicing code in takeover_tasklets() no longer has to
iterate over the list.
hm, I'd have thought that this would already have caused problems in
networking.  And perhaps this change might have effects on networking too?

Probably it won't have _much_ effect on networking because networking
probably isn't queueing one tasklet per packet(!) but perhaps with bonded
channels or something like that?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help