On Saturday 02 February 2008 21:50:25 Jeff Garzik wrote:

Ondrej Zary wrote:

quoted

Hello,
this is second version of the patch. Autoloading using udev works fine
with PnP card. Hibernation now works both in PnP and ISA modes. The I/O
address used for non-pnp ISA card detection is now not released as it's
needed to wake up the card.

Manual irq and transceiver settings aren't implemented yet. Operation
with multiple cards is not tested - I'll try 3 cards in both PnP and ISA
modes. There is some code that is the same in each of the 4 probe
functions (isa, pnp, eisa and mca), which should be probably separated
into a function.

I have no EISA or MCA machine so I hope that I didn't break them.

Looks pretty good at first glance...

I'll throw it in my queue.  Want to add a signed-off-by:  ?

	Jeff

I think that the ISA resume will not work with more than 1 card. I'll fix that 
first and test with 3 cards. So the next version can include signed-off-by.

I also wonder about the old el3_cleanup_module() function - it called 
el3_common_remove for all cards. With isa_driver and pnp_driver, it oopsed - 
I think that's because the remove() functions were called by driver core on 
isa_unregister_driver (and pnp_unregister_driver) - but what about MCA and 
EISA?

-- 
Ondrej Zary