Thread (7 messages) flat view 7 messages, 3 authors, 2008-01-31

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure (was: Re: fixed phy support (warning related to FIXED_MII_100_FDX))

From: Kumar Gala <hidden>
Date: 2008-01-31 04:31:15
Also in: linuxppc-dev

From: Anton Vorontsov <redacted>
Subject: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

This patch converts cpmac to the new Fixed PHY infrastructure,  
though it
doesn't fix all the problems with that driver. I didn't even bother to
test this patch to compile, because cpmac driver is broken in  
several ways:

1. This driver won't compile by itself because lack of its header  
describing
  platform data;
2. It assumes that fixed PHYs should be created by the ethernet  
driver.
  It is wrong assumption: fixed PHYs creation is platform code  
authority,
  driver must blindly accept bus_id and phy_id platform data variables
  instead.

Also, it seem that that driver doesn't have actual in-tree users, so
nothing to fix further.

The main purpose of that patch is to get rid of the following Kconfig
warning:

scripts/kconfig/conf -s arch/powerpc/Kconfig
drivers/net/Kconfig:1713:warning: 'select' used by config symbol
'CPMAC' refers to undefined symbol 'FIXED_MII_100_FDX'

Signed-off-by: Anton Vorontsov <redacted>
---
drivers/net/Kconfig |    4 +--
drivers/net/cpmac.c |   55 +++++++++++++++ 
+----------------------------------
2 files changed, 19 insertions(+), 40 deletions(-)
applied.

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help