Re: [PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes on 64-bit arch
From: Arnaldo Carvalho de Melo <hidden>
Date: 2008-01-31 20:34:11
From: Arnaldo Carvalho de Melo <hidden>
Date: 2008-01-31 20:34:11
Em Thu, Jan 31, 2008 at 06:17:20PM -0200, Arnaldo Carvalho de Melo escreveu:
Em Thu, Jan 31, 2008 at 08:57:53PM +0100, Eric Dumazet escreveu:quoted
Hum... retrans_out should sit close to packets_out (or lost_out/sacked_out ???), please. 'struct tcp_sock' is very large on 64 bits, so I would prefer to make sure most paths dont need to touch all 24 cache lines (or 25 cache lines).That is perfectly fine, I'll replace my patch with another, that states this beyond doubt.
David, I just removed this patch from my net-2.6 tree, if you are ok with the others, please pull. - Arnaldo