Re: [PATCH] [2/2] Remove some unnecessary gotos in established_get_first()
From: Oliver Neukum <oliver@neukum.org>
Date: 2008-01-30 08:21:26
From: Oliver Neukum <oliver@neukum.org>
Date: 2008-01-30 08:21:26
Am Mittwoch, 30. Januar 2008 09:01:10 schrieb Andi Kleen:
gcc does not generate different code for return foo vs bar = foo; goto x; x: return bar; So convert it all to direct returns for better readability.
Now suppose somebody needs to change locking. He'll have to convert it back. IMHO a conditional return is worse than "goto clearly_named_label" Regards Oliver