[PATCH] SCTP: Fix miss of report unrecognized HMAC Algorithm parameter
From: Wei Yongjun <hidden>
Date: 2008-01-27 23:50:56
This patch fix miss of check for report unrecognized HMAC Algorithm parameter. When AUTH is disabled, goto fall through path to report unrecognized parameter, else, just break.
Wei Neil Horman wrote:quoted
On Wed, Jan 23, 2008 at 09:30:27AM +0900, Wei Yongjun wrote:quoted
This patch fix miss of check for report unrecognized HMAC Algorithm parameter. When AUTH is disabled, goto fall through path to report unrecognized parameter, else, just break.Acked-by: Neil Horman <nhorman@tuxdriver.com> NeilCan you please send this to netdev and CC Dave Miller.. Acked-by: Vlad Yasevich <redacted> -vlad
Signed-off-by: Wei Yongjun <redacted> Acked-by: Neil Horman <nhorman@tuxdriver.com> Acked-by: Vlad Yasevich <redacted>
--- a/net/sctp/sm_make_chunk.c 2008-01-21 00:03:25.000000000 -0500
+++ b/net/sctp/sm_make_chunk.c 2008-01-21 02:33:36.000000000 -0500@@ -2014,7 +2014,7 @@ static sctp_ierror_t sctp_verify_param(c break; case SCTP_PARAM_HMAC_ALGO: - if (!sctp_auth_enable) + if (sctp_auth_enable) break; /* Fall Through */ fallthrough: